5 replies to this topic

[Melchoire]

I'm trying to write a short python http wrapper to show at my interview. Not really having much luck so I was hoping someone can tell me what I'm doing wrong:

import urllib2

def main():
    print http_req("http://www.google.ca/", None, "")

    
def http_req(url, data, last_page):
    req = urllib2.Request(url, data)
    req.add_header("Referer", referer)
    req.add_header("User-Agent", "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 AskTbBT5/3.9.1.14019 Firefox/3.6.12")
    
    dpage = urllib2.urlopen(req)
    
    resp_data = dpage.read()
    
    return resp_date.encode('utf-8')

I was using some lines from a code that Artifeetfetish posted in this thread.

Anyways I'm not getting anything on the console except "Press any key to continue". I should be getting a print out of google's html shouldn't I?

[Pyro699]

This is what your after

import urllib2



def main():

	print http_req("http://www.google.ca/", None, "")





def http_req(url, data, last_page):

	req = urllib2.Request(url, data)

	

	#Dont set a refer header if there is no refer data to set 

	if last_page != "":

		#You should also set that to last_page  not referer

		req.add_header("Referer", last_page)

	

	req.add_header("User-Agent", "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 AskTbBT5/3.9.1.14019 Firefox/3.6.12")

	dpage = urllib2.urlopen(req)

	resp_data = dpage.read()



	#Change to resp_data  not #resp_date

	#You dont need to encode it... its already good enough to print 

	return resp_data

	

main()

[Melchoire]

This is what your after

import urllib2

def main():
	print http_req("http://www.google.ca/", None, "")


def http_req(url, data, last_page):
	req = urllib2.Request(url, data)
	
	#Dont set a refer header if there is no refer data to set 
	if last_page != "":
		#You should also set that to last_page  not referer
		req.add_header("Referer", last_page)
	
	req.add_header("User-Agent", "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 AskTbBT5/3.9.1.14019 Firefox/3.6.12")
	dpage = urllib2.urlopen(req)
	resp_data = dpage.read()

	#Change to resp_data  not #resp_date
	#You dont need to encode it... its already good enough to print 
	return resp_data
	
main()

Darn stupid mistakes >_< thanks pyro, but I'm getting the same results...

edit: nvm, it worked after I added that "main()" at the end. What is that for anyways?

[Pyro699]

Bah you replied too quickly...

you defined main as a function... i think what you meant to put is:

if __name__ == "__main__":
    print http_req("http://www.google.ca/", None, "")

but in all honesty, since this is SO simple you don't even need that if statement... you can just run it as is... i really think you need to read a few books on python before going to a job interview for this language

import urllib2

def main():
	print http_req("http://www.google.ca/", None, "")


def http_req(url, data, last_page):
	req = urllib2.Request(url, data)
	
	#Dont set a refer header if there is no refer data to set 
	if last_page != "":
		#You should also set that to last_page  not referer
		req.add_header("Referer", last_page)
	
	req.add_header("User-Agent", "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 AskTbBT5/3.9.1.14019 Firefox/3.6.12")
	dpage = urllib2.urlopen(req)
	resp_data = dpage.read()

	#Change to resp_data  not #resp_date
	#You dont need to encode it... its already good enough to print 
	return resp_data
	
#This works
main()

#And this
print http_req("http://www.google.ca/", None, "")

#And this
if __name__ == "__main__":
	print http_req("http://www.google.ca/", None, "")

Edited by Pyro699, 14 November 2010 - 10:13 PM.

[Melchoire]

Then you must be running it wrong cause if i was to copy/paste that into a script and hit run... it will work xD

Sorry it was a mistake on my part, read my edit.

All that's left is pad it out to make it look longer

[Pyro699]

Refresh xP